Refactor user-media access rules for surveys#2459
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the security posture of user-media storage by replacing a broad authenticated access rule with a more precise, role-based access control system. The changes ensure that users can only access or modify media if they have the appropriate permissions for the associated survey, thereby preventing unauthorized data exposure or manipulation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly refactors the Firebase Storage security rules for /user-media paths. It introduces fine-grained access control by adding several helper functions (getSurvey, isUnlistedOrPublic, isOneOf, canViewSurvey, canCollectData) to determine user permissions based on survey roles and visibility. Previously, any authenticated user could read and write to /user-media; now, the path includes a surveyId, and access is restricted: read access requires the user to be able to view the specific survey, and create/write access requires the user to be able to collect data for that survey. This change addresses a previous TODO to implement more specific permission-based access.
2 participants
Fixes #1373
@rfontanarosa PTAL?